Adds Text Inputs and Buttons Selector Shorthand #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #57 diff @@
===================================
Files 15 18 +3
Lines 57 73 +16
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 57 73 +16
Misses 0 0
Partials 0 0
|
|
After working on the Buttons shorthand, I'm going to refactor this a bit to use a shared helper and leverage tagged template literals to produce the selectors. |
bhough
changed the title
mxstbr
requested changes
Dec 16, 2016
| | null | ||
| | string; | ||
|
|
||
| function statefulSelectors(states: Array<State>, template: Function, stateMap: ?Array<State>) { |
There was a problem hiding this comment.
Would be nice to have a small high-level comment explaining why we need this!
| * const div = styled.div` | ||
| * ${buttons('active')} { | ||
| * border: none; | ||
| * } |
There was a problem hiding this comment.
This actually doesn't make sense like this in styled-components, if anything this should be:
const div = styled.div`
> ${buttons('active')} {
border: none;
}
`| * | ||
| * // styled-components usage | ||
| * const div = styled.div` | ||
| * ${textInputs('active')} { |
|
@mxstbr should be good now assuming CI passes. |
Closed
mxstbr
reviewed
Dec 16, 2016
| "hiDPI", | ||
| "selection", | ||
| "placeholder", | ||
| "retinaImage", |
There was a problem hiding this comment.
Those were done in #59 🙈 Would you mind merging that first, rebasing on top of master and then adding the shorthands? Thanks and sorry for the troubles!
Adds shorthand helper for textInput selectors, including active, focus, and hover states.
buttons and textInputs shorthand now use a shared internalHelper statefulSelectors. Also removed build export for polished.
Updated styled-components example in buttons and textInputs. Added private doc explaining why we use the statefulSelectors internal helper
Update TOC with missing modules
Rebuild
mxstbr
approved these changes
Dec 16, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shorthand helper for textInput and buttonsselectors, including active, focus, and hover states.