bugfixing the AVX2 Extract8+16 codes, where there's lines like [...] #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will adjust this one to match #2 (comment) and formatting style as well. |
…6d scale01234567 = _mm256_loadu_ps(scales)`, i.e. loading float vectors into double vector types. Extract from tesseract-ocr#3490.
GerHobbelt
force-pushed
the
tfloat-patch-4
branch
from
ba85ac4 to
81b69b0
Compare
|
@stweil: code reformatted according to editor spec file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tfloat patch 4: bugfixes for AVX2 FAST_FLOAT Extract8+16 implementations tesseract-ocr#3494
Extract from tesseract-ocr#3490 - bugfixing the AVX2 Extract8+16 codes, where there's lines like __m256d scale01234567 = _mm256_loadu_ps(scales), i.e. loading float vectors into double vector types. Extract from tesseract-ocr#3490.
Note: next pullreq is a reduced version of this: less code duplication for bleeding edge tfloat branch.
Note: tesseract-ocr#3495 is this one (tesseract-ocr#3494) PLUS FAST_FLOAT condition only applied to the ExtractXYZ calls, as the others are good to go with only their prototype adjusted from double --> TFloat. Hence tesseract-ocr#3495 is only moving code compared to this one, no code change. (I don't know what diff tools you use, but thus this one (tesseract-ocr#3494) would be easier to diff/review, and then verify that tesseract-ocr#3495 is only copy/cut/paste work, resulting in a much larger diff)
[Edit: here's how this one's diff looks over at my place with BeyondCompare as diff visualizer: at least for me, much easier to 'read' than github's webview: