extracted from 3490: implements DotProductSSE() for FAST_FLOAT #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
requested changes
Jul 13, 2021
src/arch/dotproductsse.cpp
Outdated
| total += u[k] * v[k]; | ||
| } | ||
| return total; | ||
| int max_offset = n - 4; |
There was a problem hiding this comment.
Please use spaces for indentation as in the rest of the code.
src/arch/dotproductsse.cpp
Outdated
Comment on lines
56
to
57
| } | ||
| else { |
There was a problem hiding this comment.
Suggested change
| } | |
| else { | |
| } else { |
src/arch/dotproductsse.cpp
Outdated
| } | ||
| #else | ||
| double DotProductSSE(const double *u, const double *v, int n) { | ||
| TFloat DotProductSSE(const TFloat *u, const TFloat *v, int n) { |
GerHobbelt
force-pushed
the
tfloat-AVX-SSE-etc
branch
from
a220999 to
29e2379
Compare
|
@stweil: should conform to #2 (comment) and your comments now. Force-pushed the changes so it stays a single commit, keeping my messing about out of it. 😄 (MSVC editor picked up the editor format file, oddly enough only after restart. Anyway.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tfloat patch 3: implements DotProductSSE() for FAST_FLOAT tesseract-ocr#3493
extract from tesseract-ocr#3490. Tested to produce the correct numbers in the benchmark mentioned in tesseract-ocr#3486