Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc-tools binary dependency to v1.11.3 which has pre-compiled M1 binaries #26

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

gregmagolan-codaio
Copy link
Contributor

v1.11.3 is the first version of grpc-tools to ship with precompiled binaries for M1.

See grpc/grpc-node#1405 (comment).

This solves the following issue that can happen on M1:

node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using [email protected]
node-pre-gyp info using [email protected] | darwin | arm64
node-pre-gyp info check checked for "/Users/gregmagolan/src/coda/node_modules/grpc-tools/bin/grpc_tools.node" (not found)
node-pre-gyp http GET https://node-precompiled-binaries.grpc.io/grpc-tools/v1.11.2/darwin-arm64.tar.gz
node-pre-gyp ERR! install response status 404 Not Found on https://node-precompiled-binaries.grpc.io/grpc-tools/v1.11.2/darwin-arm64.tar.gz 
node-pre-gyp ERR! install error 
node-pre-gyp ERR! stack Error: response status 404 Not Found on https://node-precompiled-binaries.grpc.io/grpc-tools/v1.11.2/darwin-arm64.tar.gz
node-pre-gyp ERR! stack     at /Users/gregmagolan/src/coda/node_modules/@mapbox/node-pre-gyp/lib/install.js:67:15
node-pre-gyp ERR! stack     at processTicksAndRejections (node:internal/process/task_queues:96:5)
node-pre-gyp ERR! System Darwin 21.6.0
node-pre-gyp ERR! command "/private/var/tmp/_bazel_gregmagolan/992bb88de044c9af314b149412f58114/external/nodejs_darwin_arm64/bin/nodejs/bin/node" "/Users/gregmagolan/src/coda/node_modules/grpc-tools/node_modules/.bin/node-pre-gyp" "install"
node-pre-gyp ERR! cwd /Users/gregmagolan/src/coda/node_modules/grpc-tools
node-pre-gyp ERR! node -v v16.17.1
node-pre-gyp ERR! node-pre-gyp -v v1.0.10
node-pre-gyp ERR! not ok 
response status 404 Not Found on https://node-precompiled-binaries.grpc.io/grpc-tools/v1.11.2/darwin-arm64.tar.gz

@stultuss stultuss merged commit 5b052d3 into stultuss:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants