This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
[Dont Merge Yet] Fix PHP unit errors with wp-env phpunit container removal #182
+47
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Summary of changes
In the wp-env project (inside Gutenberg repo), the PHPUnit and Composer packages were removed.
This resulted in PHPunit tests failing to run using wpp-scripts with the message:
The 'phpunit' container has been removed. Please use 'wp-env run tests-cli --env-cwd=wp-content/path/to/plugin phpunit' instead.
In fixing it, I was getting this error:
PHP Fatal error: Declaration of PatternManager\PatternDataHandlers\PatternDataHandlersTest::setUp() must be compatible with Yoast\PHPUnitPolyfills\TestCases\TestCase::setUp(): void in /var/www/html/wp-content/plugins/pattern-manager/wp-modules/pattern-data-handlers/tests/PatternDataHandlersTest.php on line 23
The fix is to make sure that setUp and tearDown declarations have a void declared for their return type.
I was also seeing errors for
Array to string conversion
ontest_register_pattern_post_type_meta_types
. This is apparently the error message you get if you usearray_diff
but one of them is multi-dimentional.How to test
npm run test:phpunit