-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional modal for editor fields #93
Merged
Merged
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d7dbfe5
Initial POC of the editor modal
kienstra c731c4a
Merge in develop, resolve conflict
kienstra bc9961e
In composer.json, add a lint and lint-fix script
kienstra 2a1ba28
Access isSelected from blockProps
kienstra ef4ff50
Remove needless brackets and return statements
kienstra 446f7c4
Simplify the <EditorForm> rendering
kienstra 4a76b10
Do npm run packages-update for WP packages
kienstra 066dfd0
Update more packages to work on getting Jest tests to pass
kienstra 8967ec8
Revert changes to package-lock.json and package.json
kienstra e84633f
Add a checkbox to display in the modal
kienstra 11132c5
Remove 2 extra spaces in composer.json
kienstra 02704ee
Inline the handleChange() function in the onChange prop
kienstra 52239d8
Remove some needless patterns from .gitignore
kienstra 254add0
Add Jest tests for the modal
kienstra ad8a33d
Add an ESLint rule for the textdomain in i18n functions
kienstra 25e8c7a
Change the styling to only look for .block-form, not other wrapping s…
kienstra 6e9f837
Remove default values from <MediaUpload> and <FormFileUpload>
kienstra f026292
Possible solution to bug, though it takes too long
kienstra 259c00f
Revert "Possible solution to bug, though it takes too long"
kienstra 6d63f9d
Fix an issue with a <MediaUpload> inside the <Modal>
kienstra 142fb4b
Add an assertion that displayModal is false
kienstra e4b2fe1
Fix the styling in the Inspector
kienstra 3244538
Fix an issue where the Color control had missing styling
kienstra 2a64981
Add Inner Blocks and File field to README.md
kienstra 16faf33
Use Phil's idea for <label> text for the checkbox
kienstra 71b9aba
Add a correct title for the <Modal>
kienstra ed3c4f1
Ensure that the slug is lower case
kienstra 41e347d
Allow multiple block titles, as it's now in the <Modal> header
kienstra d07a86b
Don't call toBeInTheDocument() in test
kienstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
save-exact = true | ||
engine-strict = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,12 @@ | |
} | ||
}, | ||
"scripts": { | ||
"lint": [ | ||
"phpcs" | ||
], | ||
"lint-fix": [ | ||
"phpcbf" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might as well run |
||
], | ||
"test": [ | ||
"phpunit" | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but some of these ignores aren't needed.