Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phpcs error from function not having a space after it #158

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix phpcs error from function not having a space after it #158

merged 1 commit into from
Aug 31, 2023

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Aug 30, 2023 •
edited
Loading

Changes

  • Makes CI/CD pass again by fixing a phpcs error

Testing instructions

Not needed

@kienstra kienstra changed the title Fix phpcs error from function not having a space after it Fix phpcs error from function not having a space after it Aug 30, 2023
@kienstra kienstra marked this pull request as ready for review August 30, 2023 22:35
mike-day
mike-day approved these changes Aug 31, 2023
View reviewed changes
Copy link

@mike-day mike-day left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @kienstra!

I know you said testing was not needed, but I tried running against phpcs locally. Interestingly enough, linting passed both with and without the space.

@kienstra
Copy link
Contributor Author

kienstra commented Aug 31, 2023 •
edited
Loading

Thanks a lot, @mike-day!

Interestingly enough, linting passed both with and without the space.

Haha, maybe that's from different PHP versions.

@kienstra kienstra merged commit 7f9c43d into develop Aug 31, 2023
@kienstra kienstra deleted the fix/linting-php branch August 31, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-day mike-day mike-day approved these changes

@dreamwhisper dreamwhisper Awaiting requested review from dreamwhisper

@johnstonphilip johnstonphilip Awaiting requested review from johnstonphilip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kienstra @mike-day