Update e2e tests so they pass with WP 5.9
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
changed the title
kienstra
commented
Jan 20, 2022
| @@ -187,7 +187,7 @@ describe( 'AllFields', () => { | |||
| await page.click( `[value=${ fields.radio.value }` ); | |||
|
|
|||
| // Click away from the block so the <ServerSideRender> displays. | |||
| await ( await findByRole( $blockEditorDocument, 'button', { name: 'Document' } ) ).click(); | |||
| await ( await findByRole( $blockEditorDocument, 'textbox', { name: /add title/i } ) ).click(); | |||
There was a problem hiding this comment.
Clicking away from the block is hacky, I've had to change this several times.
They actually didn't bump the Core version.
kienstra
changed the title
kienstra
changed the title
kienstra
changed the title
5.9
kienstra
requested review from
mikemcalister,
dreamwhisper and
johnstonphilip
dreamwhisper
approved these changes
Jan 26, 2022
|
Thanks so much, @dreamwhisper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
5.9-RC35.9-RC3, including Twenty TwentytwoTesting Instructions