Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CI config to use non-deprecated images #104

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Update the CI config to use non-deprecated images #104

merged 3 commits into from
Jan 11, 2022

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Jan 7, 2022 •
edited
Loading

Changes

Testing instructions

  • Not needed, this really only touches testing and dev files

@kienstra kienstra changed the title Allow phpcs installer to install plugins Update the CI config to use non-deprecated images Jan 7, 2022
kienstra
kienstra commented Jan 7, 2022
View reviewed changes
composer.json
@@ -17,6 +17,11 @@
"wp-coding-standards/wpcs": "2.2.0",
"phpunit/phpunit": "7.5.2"
},
"config": {
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
Copy link
Contributor Author

@kienstra kienstra Jan 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In response to a failed job

@kienstra kienstra marked this pull request as ready for review January 7, 2022 20:48
@mikemcalister mikemcalister self-requested a review January 10, 2022 20:03
mikemcalister
mikemcalister approved these changes Jan 10, 2022
View reviewed changes
Copy link

@mikemcalister mikemcalister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@kienstra
Copy link
Contributor Author

Thanks a lot, @mikemcalister!

@kienstra kienstra merged commit 2f0f6d9 into develop Jan 11, 2022
@kienstra kienstra deleted the update/ci-config branch January 11, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemcalister mikemcalister mikemcalister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kienstra @mikemcalister