Build instead of Status in build webhook #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… core group Status as full-qualified type" This reverts commit e543124.
sttts
force-pushed
the
sttts-rebase-1.6.1-build-webhook
branch
from
4a4eadb to
fcd3975
Compare
deads2k
reviewed
Apr 13, 2017
hack/test-end-to-end.sh
Outdated
| fi | ||
| echo "++ Docker is not installed, running end-to-end against local binaries" | ||
| fi | ||
| #if [[ "${TEST_END_TO_END:-}" != "direct" ]]; then |
There was a problem hiding this comment.
Just a workaround for a node issue... which might be fixed with the new AMI.
|
Looks like you may have disabled a test. lgtm otherwise though. |
sttts
force-pushed
the
sttts-rebase-1.6.1-build-webhook
branch
from
fcd3975 to
8a24c9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the Status type as
New()value for the build webhook storage.