REVISIT/TODO: fix-test: semantic equality for pkg/deploy roundtrip tests

sttts · Apr 19, 2017 · 766b1de · 766b1de · sttts · Apr 19, 2017
1 parent 3439803
commit 766b1de
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/deploy/api/v1/defaults_test.go b/pkg/deploy/api/v1/defaults_test.go
@@ -557,7 +557,8 @@ func TestDefaults(t *testing.T) {
 			t.Errorf("unexpected object: %v", got)
 			t.FailNow()
 		}
-		if !reflect.DeepEqual(got.Spec, expected.Spec) {
+		// TODO(rebase): check that there are no fields which have different semantics for nil and []
+		if !kapi.Semantic.DeepEqual(got.Spec, expected.Spec) {
 			t.Errorf("got different than expected:\nA:\t%#v\nB:\t%#v\n\nDiff:\n%s\n\n%s", got, expected, diff.ObjectDiff(expected, got), diff.ObjectGoPrintSideBySide(expected, got))
 		}
 	}