Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: An integration test for F# #2608

Merged
merged 14 commits into from
Jul 28, 2023
Merged

chore: An integration test for F# #2608

merged 14 commits into from
Jul 28, 2023

Conversation

psfinaki
Copy link
Contributor

  • This fixes a hard crash happening currently for F# projects and adds an integration test to keep an eye on that.
  • The integration test basically just verifies no crash and only runs on Ubuntu to save the pipeline resources.
  • Also, a couple of small things

@psfinaki
Copy link
Contributor Author

Alright, as of now this only works on Windows. I don't have a Linux machine but the things seem to work in docker... weird.

@psfinaki
Copy link
Contributor Author

Okay folks so I managed to reproduce it on WSL, indeed things break on Linux (and MacOS respectively). Most probably it's related to some wrong FSharpChecker configuration we have in FSharpCompilingProcess but I am running out of ideas now. Some possibly related stuff: this, this, this.

I'd get back to that since I'll be definitely accessing FSharpCompilingProcess in the future work. Meanwhile, would you mind having the integration test running on Windows in CI? As of now, this adds 30 secs pipeline time.

@psfinaki
Copy link
Contributor Author

Hm now seems like something happened to the pipeline - artifacts are not published. This seems to be unrelated...

@rouke-broersma
Copy link
Member

rouke-broersma commented Jul 26, 2023 •
edited
Loading

Looks like myget is gone: MyGet/MyGetDocs#143 Crap

I fixed it by moving to a different nuget host

@psfinaki
Copy link
Contributor Author

@rouke-broersma thanks for the prompt fix!

Yeah apparently this PR is hitting all kinds of obstacles, now flaky tests, again unrelated :D
Fixing them here: #2611

@psfinaki
Copy link
Contributor Author

Okay so this is green again - can this go in?

@rouke-broersma rouke-broersma changed the title An integration test for F# chore: An integration test for F# Jul 28, 2023
@rouke-broersma rouke-broersma merged commit 4f081bc into stryker-mutator:master Jul 28, 2023
@psfinaki psfinaki deleted the fsharp-10 branch July 28, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickBlons PierrickBlons PierrickBlons left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psfinaki @rouke-broersma @PierrickBlons