-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ProgressReport): Replace progress reporting #1286
Conversation
Implement ShellProgressBar and make MutantsResultReporter obsolete
Looks good to me 🐝 |
Mhm after testing it looks like the fancy progress bar does not work correctly in the visual studio debug console This happens only when debug logging is turned on In git bash it fails completely It does work in CMD, but only with debug logging off: Git bash and the visual studio debug console are probably not the main shells used to run stryker but it suggests to me that the used library does not support all shells so a bit more error handling could not hurt. Especially the issue in git bash is concerning because that is the same issue we noticed on macOSX before and is why we disabled replacing values when Console.CursorTop caused an exception: stryker-net/src/Stryker.Core/Stryker.Core/Reporters/Progress/ConsoleOneLineLogger.cs Lines 62 to 74 in b05a5f9
|
Mpdreamz/shellprogressbar#22 |
Does anyone know someone with a mac that could test this pr? 😅 |
@vngrp has a mac, maybe he could take a look? |
Ah missed that remark. |
Unfortunately that seems like a regression compared to the current implementation (on some terminals). Sorry for the wait. |
No problem, it's your project after all. |
For showing addition logging we could reroute to the WriteLine function mentioned here: Mpdreamz/shellprogressbar#31 (comment) |
…ush. This so that the final reporting is the last thing on the console.
… is there after all logging.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Implement ShellProgressBar and make MutantsResultReporter obsolete
This is a WIP, to first get some feedback.
Added Unit testing.
Closes #519