feat(range): remove Range from the API #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Mutant.rangefrom the plugin API. Plugin creators should rely onlocationinstead (which hasstartandendpositions). See changes in the TypeScript checker for an example.The
rangeproperty was a way to identify changed code. It was a tuple defined as[start: number, end: number]. As plugin creator, you had the opportunity to use this instead oflocation. We've chosen to remove it because having 2 ways to identify location is redundant and this will allow us to implement #322 in the future.BREAKING CHANGE: The
rangeproperty is no longer present on amutant. Note, this is a breaking change for plugin creators only.