Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ESlint migration & prettier #1731

Merged
merged 13 commits into from
Oct 17, 2019
Merged

refactor: ESlint migration & prettier #1731

merged 13 commits into from
Oct 17, 2019

Conversation

bartekleon
Copy link
Member

@bartekleon bartekleon commented Sep 18, 2019

fixes: #1719
fixes: #1271

@bartekleon
Copy link
Member Author

Nico... I am soo sorry :< and you probably know why. But this prettier was so nicely configured by default and that array-type looks much better now >_<

@bartekleon bartekleon changed the title preparation for eslint (work in progress) refactor: ESlint migration & prettier Sep 20, 2019
@bartekleon
Copy link
Member Author

travis... hello? I have removed TSlint -.-

@bartekleon bartekleon closed this Sep 20, 2019
@bartekleon bartekleon reopened this Sep 20, 2019
@bartekleon
Copy link
Member Author

bartekleon commented Sep 20, 2019

@nicojs help... Travis hates me ;-; (NVM, prune works just fine :) and everything is working so far O.o )

@bartekleon
Copy link
Member Author

IT'S GREEN YAAAAAAAAS 🎉

@bartekleon bartekleon closed this Oct 1, 2019
@bartekleon bartekleon reopened this Oct 1, 2019
@bartekleon
Copy link
Member Author

@nicojs If you could check & possibly merge this it would be nice <3 :3

@nicojs
Copy link
Member

nicojs commented Oct 17, 2019

This looks really good! I'll have a closer look later today and if everything goes well I'll merge it. Thanks a lot! 👍

@nicojs
Copy link
Member

nicojs commented Oct 17, 2019

I've added configuration to fix-on-save in vscode.

I absolutely love some of the rules eslint brings to the table. We should enable more rules :). For example @typescript-eslint/no-floating-promises. There is no reason to have dangling promises, and they probably all bugs. Enabling the rule will show a couple of bugs. We can enable rules in separate issues IMHO, not in this one.

@bartekleon
Copy link
Member Author

Love it @nicojs! For now it would be nice if you merge it. Then we can discuss other rules which should be changed! (Take a consideration that for now @typescript-eslint is ~beta version - it doesn't have all features it had before, and so some are missing like ordered-imports [unless they changed it in some last versions])

@nicojs nicojs merged commit 9c693ee into stryker-mutator:master Oct 17, 2019
@bartekleon bartekleon deleted the eslint-migration branch October 17, 2019 19:28
@nicojs
Copy link
Member

nicojs commented Oct 17, 2019

Yeah, I've tried to enable ordered imports. It works, but it doesn't have the autofix feature: https://eslint.org/docs/rules/sort-imports

The --fix option on the command line automatically fixes some problems reported by this rule: multiple members on a single line are automatically sorted (e.g. import { b, a } from 'foo.js' is corrected to import { a, b } from 'foo.js'), but multiple lines are not reordered.

Never mind that for now. Thanks a lot once again. Logging off for tonight 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESlint migration Add prettier to development flow
2 participants