-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ESlint migration & prettier #1731
Conversation
Nico... I am soo sorry :< and you probably know why. But this prettier was so nicely configured by default and that |
travis... hello? I have removed TSlint -.- |
@nicojs help... Travis hates me ;-; (NVM, prune works just fine :) and everything is working so far O.o ) |
IT'S GREEN YAAAAAAAAS 🎉 |
@nicojs If you could check & possibly merge this it would be nice <3 :3 |
This looks really good! I'll have a closer look later today and if everything goes well I'll merge it. Thanks a lot! 👍 |
I've added configuration to fix-on-save in vscode. I absolutely love some of the rules eslint brings to the table. We should enable more rules :). For example |
Love it @nicojs! For now it would be nice if you merge it. Then we can discuss other rules which should be changed! (Take a consideration that for now @typescript-eslint is ~beta version - it doesn't have all features it had before, and so some are missing like |
Yeah, I've tried to enable ordered imports. It works, but it doesn't have the autofix feature: https://eslint.org/docs/rules/sort-imports
Never mind that for now. Thanks a lot once again. Logging off for tonight 🍻 |
fixes: #1719
fixes: #1271