Switch to using "go.uber.org/zap" for structured logging. #820
Conversation
fancycode
force-pushed
the
zap-logging
branch
from
1b285a1
to
f953695
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -330,11 +332,15 @@ | |||
| go c.processMessages() | |||
|
|
|||
| addr := c.RemoteAddr() | |||
| log := c.log.With( | |||
| zap.String("addr", addr), | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| @@ -448,11 +472,19 @@ | |||
| return false | |||
| } | |||
|
|
|||
| log := c.log.With( | |||
| zap.String("addr", c.RemoteAddr()), | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| @@ -461,11 +493,18 @@ | |||
| close: | |||
| c.conn.SetWriteDeadline(time.Now().Add(writeWait)) // nolint | |||
| if err := c.conn.WriteMessage(websocket.CloseMessage, closeData); err != nil { | |||
| log := c.log.With( | |||
| zap.String("addr", c.RemoteAddr()), | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| @@ -536,11 +581,17 @@ | |||
| msg := strconv.FormatInt(now, 10) | |||
| c.conn.SetWriteDeadline(time.Now().Add(writeWait)) // nolint | |||
| if err := c.conn.WriteMessage(websocket.PingMessage, []byte(msg)); err != nil { | |||
| log := c.log.With( | |||
| zap.String("addr", c.RemoteAddr()), | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| @@ -856,7 +890,9 @@ | |||
|
|
|||
| client, ok := c.(*Client) | |||
| if !ok { | |||
| log.Printf("Can't register non-client %T", c) | |||
| h.log.Warn("Can't register non-client", | |||
| zap.Any("client", c), | |||
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| if err != nil { | ||
| log.Printf("Could not create client for %s: %s", addr, err) | ||
| log.Error("Could not create client", | ||
| zap.String("addr", addr), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| zap.Any("candidate", candidate), | ||
| zap.Any("streamtype", client.StreamType()), | ||
| zap.String("id", client.Id()), | ||
| zap.Any("client", client), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| s.log.Warn("Received ice completed event from unknown client", | ||
| zap.Any("streamtype", client.StreamType()), | ||
| zap.String("id", client.Id()), | ||
| zap.Any("client", client), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| log.Printf("Detected bruteforce attempt on \"%s\" from %s", action, client) | ||
| t.log.Info("Detected bruteforce attempt", | ||
| zap.String("action", action), | ||
| zap.String("client", client), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
| log.Printf("Failed attempt on \"%s\" from %s, throttling by %s", action, client, delay) | ||
| t.log.Info("Failed attempt, throttling", | ||
| zap.String("action", action), | ||
| zap.String("client", client), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
fancycode
force-pushed
the
zap-logging
branch
from
f953695
to
4771d5d
Compare
Pull Request Test Coverage Report for Build 10872977727Details
💛 - Coveralls |
No description provided.