Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect sessions with the same room session id synchronously. #294

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

fancycode
Copy link
Member

Previously there was a difference in the events being received by other sessions for the clustered case compared to the single-server case. Now the events / ordering are the same for both cases.

Previously there was a difference in the events being received by other
sessions for the clustered case compared to the single-server case.
Now the events / ordering are the same for both cases.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2648326230

  • 19 of 19 (100.0%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 51.619%

Files with Coverage Reduction New Missed Lines %
clientsession.go 7 60.95%
Totals Coverage Status
Change from base Build 2637002700: 0%
Covered Lines: 6425
Relevant Lines: 12447

💛 - Coveralls

@fancycode fancycode merged commit 13d2795 into master Jul 11, 2022
@fancycode fancycode deleted the synchronous-roomsession-disconnect branch July 11, 2022 08:53
mwalbeck added a commit to mwalbeck/docker-nextcloud-spreed-signaling that referenced this pull request Aug 6, 2022
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [strukturag/nextcloud-spreed-signaling](https://github.com/strukturag/nextcloud-spreed-signaling) | major | `v0.5.0` -> `v1.0.0` |

---

### Release Notes

<details>
<summary>strukturag/nextcloud-spreed-signaling</summary>

### [`v1.0.0`](https://github.com/strukturag/nextcloud-spreed-signaling/releases/tag/v1.0.0)

[Compare Source](strukturag/nextcloud-spreed-signaling@v0.5.0...v1.0.0)

##### Added

-   Clustering support.  [#&#8203;281](strukturag/nextcloud-spreed-signaling#281)
-   Send initial "welcome" message when clients connect.  [#&#8203;288](strukturag/nextcloud-spreed-signaling#288)
-   Support hello auth version "2.0" with JWT.  [#&#8203;251](strukturag/nextcloud-spreed-signaling#251)
-   dist: add systemd sysusers file.  [#&#8203;275](strukturag/nextcloud-spreed-signaling#275)
-   Add more tests.  [#&#8203;292](strukturag/nextcloud-spreed-signaling#292)
-   Add tests for virtual sessions.  [#&#8203;295](strukturag/nextcloud-spreed-signaling#295)
-   Implement per-backend session limit for clusters.  [#&#8203;296](strukturag/nextcloud-spreed-signaling#296)

##### Changed

-   Don't run "go mod tidy" when building.  [#&#8203;269](strukturag/nextcloud-spreed-signaling#269)
-   Bump sphinx from 5.0.0 to 5.0.1 in /docs  [#&#8203;270](strukturag/nextcloud-spreed-signaling#270)
-   Bump sphinx from 5.0.1 to 5.0.2 in /docs  [#&#8203;277](strukturag/nextcloud-spreed-signaling#277)
-   Move common etcd code to own class.  [#&#8203;282](strukturag/nextcloud-spreed-signaling#282)
-   Support arbitrary capabilities values.  [#&#8203;287](strukturag/nextcloud-spreed-signaling#287)
-   dist: harden systemd service unit.  [#&#8203;276](strukturag/nextcloud-spreed-signaling#276)
-   Update to Go module version of github.com/golang-jwt/jwt  [#&#8203;289](strukturag/nextcloud-spreed-signaling#289)
-   Disconnect sessions with the same room session id synchronously.  [#&#8203;294](strukturag/nextcloud-spreed-signaling#294)
-   Bump google.golang.org/grpc from 1.47.0 to 1.48.0  [#&#8203;297](strukturag/nextcloud-spreed-signaling#297)
-   Update to github.com/pion/sdp v3.0.5  [#&#8203;301](strukturag/nextcloud-spreed-signaling#301)
-   Bump sphinx from 5.0.2 to 5.1.1 in /docs  [#&#8203;303](strukturag/nextcloud-spreed-signaling#303)
-   make: Include vendored dependencies in tarball.  [#&#8203;300](strukturag/nextcloud-spreed-signaling#300)
-   docs: update and pin dependencies.  [#&#8203;305](strukturag/nextcloud-spreed-signaling#305)
-   Bump actions/upload-artifact from 2 to 3  [#&#8203;307](strukturag/nextcloud-spreed-signaling#307)
-   Bump actions/download-artifact from 2 to 3  [#&#8203;308](strukturag/nextcloud-spreed-signaling#308)
-   Bump google.golang.org/protobuf from 1.28.0 to 1.28.1  [#&#8203;306](strukturag/nextcloud-spreed-signaling#306)
-   CI: Also test with Golang 1.19  [#&#8203;310](strukturag/nextcloud-spreed-signaling#310)

##### Fixed

-   Fix check for async room messages received while not joined to a room.  [#&#8203;274](strukturag/nextcloud-spreed-signaling#274)
-   Fix testing etcd server not starting up if etcd is running on host.  [#&#8203;283](strukturag/nextcloud-spreed-signaling#283)
-   Fix CI issues on slow CPUs.  [#&#8203;290](strukturag/nextcloud-spreed-signaling#290)
-   Fix handling of "unshareScreen" messages and add test.  [#&#8203;293](strukturag/nextcloud-spreed-signaling#293)
-   Fix Read The Ddocs builds.  [#&#8203;302](strukturag/nextcloud-spreed-signaling#302)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->

Co-authored-by: Magnus Walbeck <[email protected]>
Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-spreed-signaling/pulls/207
Co-authored-by: renovate-bot <[email protected]>
Co-committed-by: renovate-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants