-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chroma downsampling and upsampling algorithms dont't work with heif_chroma_422
#936
Comments
@farindk Are you aware of the problem? Does it seem meaningful to you? |
Yes, we don't have a 4:2:2 to 4:4:4 bilinear upsampling algorithm implemented. I thought that was low priority because 4:2:2 is basically never used for images. It was meant for interlaced video, but is pretty useless for still images. Usually I could add a 4:2:2 to 4:4:4 bilinear implementation, just in case. |
Why do you think so? It reduces amount of data a lot with moderate impact on visual quality. We use it for most our saved images. |
Seems that we need a 4:2:2 to 4:4:4 implementation to be able to set use |
Please also check that these conversions work as expected. Especially at the image borders and images with odd width. |
@farindk Thanks! I will try to do this within the day |
@farindk is gpu hardware accelerators supports for chroma subsampling 422 files? |
No. There is no GPU acceleration for any chroma format yet. |
Expected
heif_chroma_422
is one of the downsampling options forRGB
→YCbCr
conversion. Likeheif_chroma_420
, it also removes data fromCbCr
channels. So there are should be a way to enable the average downsampling and upsampling.Actual result
Additional
Combining with #935 this leads to that there is no way to decode the image with
bilinear
algorithm. If you setonly_use_preferred_chroma_algorithm
, it will breaks onheif_chroma_422
images and there is not way to find actual subsampling of the image before callingheif_decode_image
, just as there is no way to setpreferred_chroma_downsampling_algorithm
after callingheif_decode_image
. If you woudn't setonly_use_preferred_chroma_algorithm
, thepreferred_chroma_downsampling_algorithm
will be ignored.The text was updated successfully, but these errors were encountered: