Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not handling errors after client invoke() #160

Closed
ritch opened this issue Jan 14, 2015 · 1 comment · Fixed by #161
Closed

Not handling errors after client invoke() #160

ritch opened this issue Jan 14, 2015 · 1 comment · Fixed by #161
Assignees
@ritch

Comments

@ritch
Copy link
Member

ritch commented Jan 14, 2015

https://github.com/strongloop/strong-remoting/blob/master/lib/rest-adapter.js#L121

The err is not handled from this callback.
@ritch ritch self-assigned this Jan 14, 2015
@BerkeleyTrue
Copy link
Contributor

I'm on it.

@BerkeleyTrue BerkeleyTrue mentioned this issue Jan 14, 2015
Merged
bajtos pushed a commit that referenced this issue Feb 3, 2015
Merge tag 'v2.12.1'
2593cc9 
2.12.1

 * Catch unhandled error on current method invocation (Pradnya Baviskar)

 * Fix jscs settings (Miroslav Bajtoš)

 * Remove use of deprecated `req.param()` in express (Seth Etter)

 * Update simple example (Ritchie Martori)

 * Handle Http Invoke Errors Fixes #160 (Berkeley Martinez)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ritch ritch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle Http Invoke Errors
2 participants
@ritch @BerkeleyTrue