Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description for persisted-models #4158

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Update the description for persisted-models #4158

merged 3 commits into from
Mar 15, 2019

Conversation

qpresley
Copy link

Description

The description for the filter in persisted-models.js was not clear on what the filter JSON should look like. This PR improves the example and adds a link for further description.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@bajtos bajtos self-assigned this Mar 15, 2019
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qpresley for the pull request, the changes LGTM.

Let's wait for CI results before landing.

@bajtos bajtos merged commit a9a86fe into master Mar 15, 2019
@bajtos bajtos deleted the fixFilterDef branch March 15, 2019 15:05
@bajtos
Copy link
Member

bajtos commented Mar 15, 2019

Published in [email protected] 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants