Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and node version #541

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Dec 10, 2018

Updated dependencies except for the eslint and supertest dependencies and removed Gruntfile.js.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

@nabdelgadir nabdelgadir force-pushed the update-dependencies branch 4 times, most recently from b0a99a6 to bf27600 Compare December 12, 2018 14:43
package.json Outdated Show resolved Hide resolved
@nabdelgadir nabdelgadir force-pushed the update-dependencies branch 2 times, most recently from ca3c8dd to ad5fcee Compare December 13, 2018 15:56
@nabdelgadir nabdelgadir self-assigned this Dec 13, 2018
@nabdelgadir nabdelgadir changed the title [WIP] update dependencies and node version Update dependencies and node version Dec 13, 2018
@bajtos
Copy link
Member

bajtos commented Dec 14, 2018

Cross-posting some information about Grunt from a chat we had elsewhere.

I don't remember why exactly we had grunt & docular in the depencencies. Based on the Gruntfile.js, I think the idea was to generate human-readable documentation for the Angular.js client generated for workspace's REST API. I believe all consumers of those Angular.js clients are no longer actively developed, only in maintenance mode, so it should be ok to remove those grunt-related dependencies.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nabdelgadir nabdelgadir merged commit fa32281 into master Dec 18, 2018
@nabdelgadir nabdelgadir deleted the update-dependencies branch December 18, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants