-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LB version to LB3 #539
Conversation
@nabdelgadir The code base in loopback-workspace is ancient and some files (e.g. Anyhow, here are the lines where to start learning about workspace internals: loopback-workspace/server/server.js Lines 35 to 38 in f95230a
What is happening here: we are modifying I think the code inside individual model classes (Entity subclasses) should not need any changes to work in LoopBack 3.x. The code inside |
d4e9cdd
to
d3ea6dd
Compare
ok, the changes made so far looks good to me. Now we need to find out why the tests are failing.
|
149c851
to
4dee7b4
Compare
92106f6
to
d728c2f
Compare
@slnode test please |
3010008
to
248d775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
I see the downstream builds for generator-loopback are still failing. While I think those test failure should not be related to this pull request, we cannot be really sure. Let's fix generator-loopback first please. Then trigger a new build and see if all is good. I opened a pull request to fix generator-loopback tests, see strongloop/generator-loopback#399 Once it's approved & merged, we should back-port it to 5.x branch of generator-loopback too. cc @jannyHou |
Co-authored-by: Miroslav Bajtos <[email protected]>
248d775
to
a17c3c5
Compare
@slnode test please |
@nabdelgadir all CI checks are green now, yay! 🎉 |
Description
Update LoopBack version from LoopBack 2 to LoopBack 3.
Related issues
Checklist