Docs and cleanup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename "per-request-context" middleware to shorter "per-request". Introduce "LoopBackContext.perRequest" as a shortcut for way too long "loopback-context/server/middlewar/per-request"
Recommend against using this module.
|
|
||
| **We recommend AGAINST using this module.** | ||
|
|
||
| If you are running on Node v6, you can try the new alternative |
There was a problem hiding this comment.
We need another alternative that doesn't use CLS at all.
There was a problem hiding this comment.
We need another alternative that doesn't use CLS at all.
Agreed!
|
LGTM @crandmck we'll need to update the docs to mention this module. |
|
@crandmck I edited https://docs.strongloop.com/display/APIC/Using+current+context myself. PTAL and make any improvements as you deem it fit. |
|
Thanks for doing that @bajtos! I'll make an edit pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1) API cleanup
Rename "per-request-context" middleware to shorter "per-request".
Introduce "LoopBackContext.perRequest" as a shortcut for way too long
"loopback-context/server/middlewar/per-request"
2) Add big fat warning to README
@raymondfeng @ritch please review
Connect to strongloop-internal/scrum-loopback#989.