Check return value of FlushLightStepTracer #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerald Rule: Copy Observability on Veneur and Unilog pull requestscc @stripe/observability |
|
lgtm |
cory-stripe
force-pushed
the
aditya-lightstep-flush-error
branch
from
805883b to
ed9a0fc
Compare
cory-stripe
force-pushed
the
aditya-lightstep-flush-error
branch
from
ed9a0fc to
e0d3442
Compare
|
Manual re-approval post rebase |
* Currently this is always nil, so it's not actually meaningful
cory-stripe
force-pushed
the
aditya-lightstep-flush-error
branch
from
e0d3442 to
249396f
Compare
|
re-approval for rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Check return value of FlushLightStepTracer.
However, currently this is always nil, so it's not actually meaningful
Motivation
Test plan
Rollout/monitoring/revert plan
r? @stripe/observability