Allow client_id configuration on instance config #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's necessary to allow `client_id` to be configured in order to move towards supporting `StripeClient` instances.
|
Thanks Joel! This one looks good to me. |
|
Released as 5.29.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While (re)working a PR to support
StripeClientinstances, I realized that it'd likely be desirable to set theclient_idon the instance. Otherwise, users would always have to set theclient_idonStripedespite other configurations being provided when initializing aStripeClient.Turns out, it's already set up and tested, but the
attr_accessoronStripewas still lingering;Mostly breaking this out so the the
StripeClientPR isn't as noisy 😄