Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StripeError#idempotent_replayed? #907

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Feb 27, 2020

Adds an easy accessor on StripeError which indicates whether the error
occurred previously, but was replayed on this request because the user
passed the same idempotency key as that original request.

Fixes #905.

r? @ob-stripe
cc @stripe/api-libraries

Adds an easy accessor on `StripeError` which indicates whether the error
occurred previously, but was replayed on this request because the user
passed the same idempotency key as that original request.

Fixes #905.
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but LGTM!

lib/stripe/errors.rb Show resolved Hide resolved
@brandur-stripe
Copy link
Contributor

Thanks OB!

@brandur-stripe brandur-stripe merged commit f7923f7 into master Feb 27, 2020
@remi-stripe remi-stripe deleted the brandur-idempotent-replayed branch September 28, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: notate exceptions that occur with Idempotent-Replayed: true
4 participants