Explicitly pass a parameter as hash to be more ruby 2.7 friendly

[dennisvdvliet]

Ruby 2.7 started emitting some warnings when you do things that are not ruby 3.0 compatible. The way Stripe::StripeObject.update_attributes raises a number of warnings.

For example in ruby 2.7 the following will raise a warning

obj = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
obj.update_attributes(name: 'Dennis')

To make this work in ruby 2.7 we need to explicitly pass in a hash as the first argument

obj = Stripe::StripeObject.construct_from(id: 1, name: "Stripe")
obj.update_attributes({name: 'Dennis'})

👮 👮‍♀ Rubocop does not really like this so that is why there are a number of comments added to the spec to allow this explicit hash passing.

[0] https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

[brandur-stripe]

@dennisvdvliet Thank you again! Two minor asks:

1. Would you mind moving the Rubocop disable tags to each individual line instead of broadly disabling for the entire file? Just looks like this:

   obj.update_attributes({ name: "STRIPE" }) # rubocop:disable Style/BracesAroundHashParameters

2. Can you take out the .ruby-version file included in the PR? Maybe we should have one of these in a project, but I'd prefer to bring it in on its own PR so that we consider it in isolation.

Thanks!

[dennisvdvliet]

@brandur-stripe Done

[brandur-stripe]

Excellent! Thanks again.

[brandur-stripe]

Just re-ran our suite on 2.7 — after we get one more fix from Webmock, we'll be fully Ruby 2.7 warning-free!