Add a test to make sure request IDs make it into error objects #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
force-pushed
the
brandur-request-id-test
branch
from
751e49e to
761dc80
Compare
| @@ -19,8 +19,17 @@ Layout/IndentFirstHashElement: | |||
| Layout/IndentHeredoc: | |||
| Enabled: false | |||
|
|
|||
| Metrics/BlockLength: | |||
| Max: 40 | |||
There was a problem hiding this comment.
Note that we can make this much more restrictive after excluding the test directory. It moves from 509 to 40.
|
Thanks OB! |
|
Thanks folks! This is great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #845 to make sure that this sort of regression is much more
difficult in the future by adding a test that makes sure a request ID is
threaded all the way from an HTTP response back through to an error
object. I verified that the test failed before #845 came in.
r? @ob-stripe