-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Faraday's Net::HTTP::Persistent
adapter
#698
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,6 @@ | ||
language: ruby | ||
|
||
rvm: | ||
- 2.0 | ||
- 2.1 | ||
- 2.2 | ||
- 2.3 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,8 @@ | |
# we can print one error and fail fast so that it's more clear to the user how | ||
# they should fix the problem. | ||
begin | ||
resp = Faraday.get("http://localhost:#{MOCK_PORT}/") | ||
conn = Faraday::Connection.new("http://localhost:#{MOCK_PORT}") | ||
resp = conn.get("/") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to change this because using the default connection at the beginning of the test run "locked" the middleware stack and prevented me from changing the adapter above. I guess it only worked before by virtue of the fact that all the middlewares we installed were default and thus already installed (so no changes to the middleware stack needed to be made). |
||
version = resp.headers["Stripe-Mock-Version"] | ||
if version != "master" && | ||
Gem::Version.new(version) < Gem::Version.new(MOCK_MINIMUM_VERSION) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this variable name to
builder
to be more accurate and descriptive as to what's being received inside the block here.