Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_link support #669

Merged
merged 1 commit into from
Aug 3, 2018
Merged

file_link support #669

merged 1 commit into from
Aug 3, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Add support for file_links.

@remi-stripe
Copy link
Contributor

LGTM

@brandur-stripe
Copy link
Contributor

There's a linting problem that you probably saw, but otherwise LGTM.

test/stripe/file_link_test.rb:22:25: C: Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call.
        file: "file_123",

@ob-stripe ob-stripe merged commit 76a8a45 into master Aug 3, 2018
@ob-stripe ob-stripe deleted the ob-file-link branch August 3, 2018 10:25
@ob-stripe
Copy link
Contributor Author

Released as 3.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remi-stripe remi-stripe

@brandur-stripe brandur-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ob-stripe @remi-stripe @brandur-stripe