Do not colorize output destined for configured logger #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the predicate supplied to the #colorize method to ensure that if a logger is set, the colorizing ANSI escape codes are not applied. This definitely appears to have been the intention behind the original implementation, but the tests didn't reflect how .log_internal was actually called. In reality, it is always supplied with an `out:` argument, not nil. This caused all logger bound output to also be colorized.
jasonwebster
force-pushed
the
do_not_colorize_logger_logging
branch
from
1181ae9 to
9d0cd25
Compare
|
Yes, this looks more right. Thanks! |
|
Released as 3.17.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the predicate supplied to the #colorize method to ensure
that if a logger is set, the colorizing ANSI escape codes are not applied.
This definitely appears to have been the intention behind the original
implementation, but the tests didn't reflect how .log_internal was
actually called. In reality, it is always supplied with an
out:argument, not nil. This caused all logger bound output to also be
colorized.