Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for 'partner_id' in 'set_app_info' #658

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Adds support for 'partner_id' in 'set_app_info' #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15029ff
Adds support for 'partner_id' in 'set_app_info'
zwick-stripe Jun 15, 2018
389d1b4
Updates rubocop configuration
zwick-stripe Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-02-23 14:17:07 +0100 using RuboCop version 0.50.0.
# on 2018-06-28 10:59:56 -0400 using RuboCop version 0.50.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -13,18 +13,18 @@ Metrics/AbcSize:
# Offense count: 27
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 496
Max: 498

# Offense count: 8
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 624
Max: 626

# Offense count: 11
Metrics/CyclomaticComplexity:
Max: 15

# Offense count: 259
# Offense count: 269
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
Expand Down Expand Up @@ -55,6 +55,6 @@ Style/ClassVars:
- 'lib/stripe/stripe_object.rb'
- 'test/stripe/api_resource_test.rb'

# Offense count: 53
# Offense count: 55
Style/Documentation:
Enabled: false
5 changes: 3 additions & 2 deletions lib/stripe.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,11 @@ def self.max_network_retries=(val)
# with API requests. Useful for plugin authors to identify their plugin when
# communicating with Stripe.
#
# Takes a name and optional version and plugin URL.
def self.set_app_info(name, version: nil, url: nil)
# Takes a name and optional partner program ID, plugin URL, and version.
def self.set_app_info(name, partner_id: nil, url: nil, version: nil)
@app_info = {
name: name,
partner_id: partner_id,
url: url,
version: version,
}
Expand Down
2 changes: 2 additions & 0 deletions test/stripe/stripe_client_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ class StripeClientTest < Test::Unit::TestCase
old = Stripe.app_info
Stripe.set_app_info(
"MyAwesomePlugin",
partner_id: "partner_1234",
url: "https://myawesomeplugin.info",
version: "1.2.34"
)
Expand All @@ -361,6 +362,7 @@ class StripeClientTest < Test::Unit::TestCase

assert_equal({
name: "MyAwesomePlugin",
partner_id: "partner_1234",
url: "https://myawesomeplugin.info",
version: "1.2.34",
}, data[:application])
Expand Down
2 changes: 2 additions & 0 deletions test/stripe_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ class StripeTest < Test::Unit::TestCase
old = Stripe.app_info
Stripe.set_app_info(
"MyAwesomePlugin",
partner_id: "partner_1234",
url: "https://myawesomeplugin.info",
version: "1.2.34"
)
assert_equal({
name: "MyAwesomePlugin",
partner_id: "partner_1234",
url: "https://myawesomeplugin.info",
version: "1.2.34",
}, Stripe.app_info)
Expand Down