Properly encode file uploads #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in #506, file uploads were broken on the way over to Faraday and unfortunately I didn't catch it because the file upload creation test wasn't using a matcher that was strict enough to really catch anything. Here we add the multipart middleware to our Faraday connection, add a compatibility layer to `FileUpload` so that we can support `File` like the rest-client based version always did (Faraday generally expects an `UploadIO` object), and then tighten up our tests so that we'd be able to catch future regressions. Fixes #506.
|
lgtm! |
|
Thanks @ob-stripe! |
|
Released as 2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #506, file uploads were broken on the way over to
Faraday and unfortunately I didn't catch it because the file upload
creation test wasn't using a matcher that was strict enough to really
catch anything.
Here we add the multipart middleware to our Faraday connection, add a
compatibility layer to
FileUploadso that we can supportFilelikethe rest-client based version always did (Faraday generally expects an
UploadIOobject), and then tighten up our tests so that we'd be ableto catch future regressions.
Fixes #506.
r? @ob-stripe Mind taking a look at this one? Thanks!