-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supporting classes for test helper generation #1034
Conversation
CI is failing, one more file needs to be pushed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, let's wait to merge until the first test_helper
method is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one nit and then we'll be good to ship! Thanks!
PTAL @dcr-stripe ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test helper methods on a resource are placed inside a nested
TestHelpers
class:To support the generation we need:
APIResourceTestHelpers
with test-helper URL generation logic.custom_method
to handle cases where static method in not on the resource class itself.