Revert back to initialize_from from Util.convert_to_stripe_object (…

…#806)

* Revert "Use Util.convert_to_stripe_object instead of initialize_from"

This reverts commit ea736eb.

* Make SetupIntents use initialize_from instead of Util.convert_to_stripe_object

* Fix issuing card details, which must have been broken prior to ea736eb

lib/stripe/resources/account.rb

@@ -21,7 +21,7 @@ class Account < APIResource
 
     def reject(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/reject", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     save_nested_resource :external_account

lib/stripe/resources/credit_note.rb

@@ -12,7 +12,7 @@ class CreditNote < APIResource
 
     def void_credit_note(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/void", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/dispute.rb

@@ -11,7 +11,7 @@ class Dispute < APIResource
 
     def close(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/close", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def close_url

lib/stripe/resources/invoice.rb

@@ -17,27 +17,27 @@ class Invoice < APIResource
 
     def finalize_invoice(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/finalize", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def mark_uncollectible(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/mark_uncollectible", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def pay(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/pay", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def send_invoice(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/send", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def void_invoice(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/void", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def self.upcoming(params, opts = {})

lib/stripe/resources/issuing/authorization.rb

@@ -13,12 +13,12 @@ class Authorization < APIResource
 
       def approve(params = {}, opts = {})
         resp, opts = request(:post, resource_url + "/approve", params, opts)
-        Util.convert_to_stripe_object(resp.data, opts)
+        initialize_from(resp.data, opts)
       end
 
       def decline(params = {}, opts = {})
         resp, opts = request(:post, resource_url + "/decline", params, opts)
-        Util.convert_to_stripe_object(resp.data, opts)
+        initialize_from(resp.data, opts)
       end
     end
   end

lib/stripe/resources/payment_intent.rb

@@ -14,17 +14,17 @@ class PaymentIntent < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def capture(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/capture", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def confirm(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/confirm", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/payment_method.rb

@@ -13,12 +13,12 @@ class PaymentMethod < APIResource
 
     def attach(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/attach", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def detach(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/detach", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/payout.rb

@@ -12,7 +12,7 @@ class Payout < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def cancel_url

lib/stripe/resources/review.rb

@@ -10,7 +10,7 @@ class Review < APIResource
 
     def approve(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/approve", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/setup_intent.rb

@@ -13,12 +13,12 @@ class SetupIntent < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def confirm(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/confirm", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/source.rb

@@ -11,7 +11,7 @@ class Source < APIResource
 
     def verify(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/verify", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def detach(params = {}, opts = {})

lib/stripe/resources/subscription_schedule.rb

@@ -16,12 +16,12 @@ class SubscriptionSchedule < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def release(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/release", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def revisions(params = {}, opts = {})

lib/stripe/resources/topup.rb

@@ -12,7 +12,7 @@ class Topup < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
   end
 end

lib/stripe/resources/transfer.rb

@@ -16,7 +16,7 @@ class Transfer < APIResource
 
     def cancel(params = {}, opts = {})
       resp, opts = request(:post, resource_url + "/cancel", params, opts)
-      Util.convert_to_stripe_object(resp.data, opts)
+      initialize_from(resp.data, opts)
     end
 
     def cancel_url