Skip to content

Commit

Permalink
Transfer the request_id from the http_headers to error. (#845)
Browse files Browse the repository at this point in the history
When requesting error#request_id it returned nil although the request id was available in the request headers. With version 5 and switch to Net::HTTP this value is now a string, not a symbol which means that the request_id was not stored on the error correctly.
  • Loading branch information
AlicaMoser authored and brandur-stripe committed Sep 4, 2019
1 parent 4445172 commit b7495eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/stripe/errors.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def initialize(message = nil, http_status: nil, http_body: nil,
@http_headers = http_headers || {}
@json_body = json_body
@code = code
@request_id = @http_headers[:request_id]
@request_id = @http_headers["request-id"]
@error = construct_error_object
end

Expand Down
2 changes: 1 addition & 1 deletion test/stripe/errors_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class StripeErrorTest < Test::Unit::TestCase
e = StripeError.new("message", http_status: 200)
assert_equal "(Status 200) message", e.to_s

e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { request_id: "request-id" })
e = StripeError.new("message", http_status: nil, http_body: nil, json_body: nil, http_headers: { "request-id" => "request-id" })
assert_equal "(Request request-id) message", e.to_s
end
end
Expand Down

0 comments on commit b7495eb

Please sign in to comment.