Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove additional margin in cardform #1234

Merged
merged 2 commits into from
Dec 7, 2022
Merged

fix: remove additional margin in cardform #1234

merged 2 commits into from
Dec 7, 2022

Conversation

charliecruzan-stripe
Copy link
Collaborator

@charliecruzan-stripe charliecruzan-stripe commented Dec 7, 2022 •
edited
Loading

Summary

removed some no-op setPadding lines, set cardMultilineWidgetContainer margins to zero

Motivation

fixes #1172

Testing

  • I tested this manually
  • I added automated tests

before:
Screen Shot 2022-12-07 at 11 45 27 AM

after:
Screen Shot 2022-12-07 at 11 44 31 AM

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@charliecruzan-stripe charliecruzan-stripe mentioned this pull request Dec 7, 2022
Closed
@charliecruzan-stripe charliecruzan-stripe merged commit 3a475f4 into master Dec 7, 2022
@charliecruzan-stripe charliecruzan-stripe deleted the charliecruzan/fix-margin-cardform branch December 7, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CardForm margin or padding
1 participant
@charliecruzan-stripe