Stop sending raw exception message as part of Stripe user agent. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcr-stripe
force-pushed
the
dcr-crash-wrapper
branch
from
abbb1a1 to
bc7b2e4
Compare
richardm-stripe
approved these changes
Oct 7, 2021
|
Oh looks like you fixed the formatting! LGTM! |
|
|
dcr-stripe
force-pushed
the
dcr-crash-wrapper
branch
from
41a7cd0 to
9cc19aa
Compare
|
Fixed formatting, removed the PTAL @richardm-stripe |
richardm-stripe
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify
r? @richardm-stripe
cc @remi-stripe
Summary
Updates user agent generation to avoid sending the raw exception message when calling platform methods to determine user agent components. Instead just send
"(disabled)"for the failed fields.Test plan
Added unit test.