Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Person resource #482

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Add support for the Person resource #482

merged 1 commit into from
Oct 30, 2018

Conversation

remi-stripe
Copy link
Contributor

cc @stripe/api-libraries

@remi-stripe
Copy link
Contributor Author

@ob-stripe I never remember how to run the test suite locally? The tox commands never work for me unfortunately, do you know what to do?

@brandur-stripe
Copy link
Contributor

@remi-stripe This is probably not a perfect system by any means, but using Pipenv usually works for me:

pipenv install --dev
pipenv shell
tox -e py27

@remi-stripe
Copy link
Contributor Author

@brandur-stripe yeah but ob once gave me the command to run a specific test and it was using pytest or something and I can never remember the right invocation lol

@jleclanche
Copy link
Contributor

You can run specific tests matching by name with -k. eg tox -e py36 -- -xk foo will run tests on py36 env, -x will stop the test suite on the first error, and -k matches all tests that have foo in the name.

@remi-stripe
Copy link
Contributor Author

@jleclanche Ah awesome I'll try that thank you!

@remi-stripe
Copy link
Contributor Author

r? @ob-stripe

ob-stripe
ob-stripe suggested changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, LGTM otherwise.

tests/api_resources/test_account.py Outdated
def test_is_creatable(self, request_mock):
resource = stripe.Account.create_person(
TEST_RESOURCE_ID,
dob=dict(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the {'day': 1, 'month': 1, 'year': 1980} syntax instead?

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Oct 29, 2018
@remi-stripe
Copy link
Contributor Author

@ob-stripe PTAL

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Oct 29, 2018
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Oct 29, 2018
@remi-stripe remi-stripe merged commit 70ec29a into master Oct 30, 2018
@remi-stripe remi-stripe deleted the remi-add-person branch October 30, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remi-stripe @brandur-stripe @jleclanche @ob-stripe @stripe-ci