Handle file objects like file_upload
#477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Pushed another commit to only use |
| stripe.api_base = None | ||
| yield | ||
| stripe.api_base = stripe.upload_api_base | ||
| stripe.upload_api_base = 'https://files.stripe.com' |
There was a problem hiding this comment.
I'm not too familiar with the framework here, but are you sure this doesn't need to be in a finally to guarantee that these values are set back in case of an exception?
There was a problem hiding this comment.
Just tested it, and it's not necessary. The framework already catches exceptions in tests and reports them as errors, and still executes the post-yield code.
|
Left a minor comment above, but otherwise LGTM! |
ob-stripe
force-pushed
the
ob-file-resource
branch
from
dfc50bc to
94d6331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Exactly like stripe/stripe-ruby#689, but for Python.