Make custom action methods more consistent #369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @remi-stripe
Custom methods (e.g. pay an invoice, reject an account, etc.) were handled inconsistently throughout the library:
Payout.cancel
,Transfer.cancel
)Invoice.pay
,Order.pay
)Source.detach
,Payout.cancel
,Transfer.cancel
)I have not written any new tests because I'm fairly confident about these changes and because @remi-stripe is working on updating the tests to use stripe-mock in #367.I did add some tests after all.