-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes #362
Minor fixes #362
Conversation
@@ -6,4 +6,4 @@ | |||
|
|||
class InvoiceItem(CreateableAPIResource, UpdateableAPIResource, | |||
ListableAPIResource, DeletableAPIResource): | |||
OBJECT_NAME = 'invoice_item' | |||
OBJECT_NAME = 'invoiceitem' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably cut a new version for this or something to prevent many future instances of confusion around this bad naming ...
Thanks for following up with these OB! Am I good to release these changes as a patch version? (i.e. the interface of |
Yep, the interface is identical. |
Awesome. Thanks! |
Released as 1.71.2. |
r? @brandur-stripe
cc @stripe/api-libraries
A few random fixes:
removed the existing
modify_external_account
andmodify_source
class methods onAccount
andCustomer
resp. since those methods are now created by the@nested_resource_class_methods
decorator (Nested resource class methods #350)fixed the object name for
InvoiceItem
and addedBalanceTransaction
inutil.convert_to_stripe_object
. I think I broke both of these in Split resource.py #351 :/The existing
@nested_resource_class_methods
tests ensure the removed methods still actually exist. Added a very basic test to avoid regression for the other fixes.