fix autopagination for Service #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
changed the title
ob-stripe
reviewed
May 26, 2020
|
ptal @richardm-stripe |
|
Ok, will add codegen for this and release tomorrow. |
|
codegenned, |
richardm-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #939.
Briefly,
autoPagingIteratorexpects thefiltersproperty onStripe\Collectionto be set from$params.This was happening before in
\ApiOperations\All::allhttps://github.com/stripe/stripe-php/blob/master/lib/ApiOperations/All.php#L33, but isn't done inBaseStripeClient#requesthttps://github.com/stripe/stripe-php/blob/master/lib/BaseStripeClient.php#L129-L140.
This PR introduces
BaseStripeClient#requestCollection(andAbstractService#requestCollection, to call it), which simply calls#requestand then->setFilters($params), and then we updated the "SubscriptionService" to use it.ptal @ob-stripe to see if this seems right (feel free to bikeshed on naming)
I prefer adding a separate #requestCollection method rather than adding the call conditionally to
#request-- since->allshould always return a\Stripe\Collection, it seems better that it call a method guaranteed to return the narrower\Stripe\Collectionrather than the broader\Stripe\Object