Add pending update constants #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remi-stripe is there any chance you can give this a review? :) |
|
@driesvints Sorry for the delay on that one and dropping the ball. We'll investigate this week and either merge or come back to you with changes. We need to do some work internally as stripe-php is automatically generated from the openapi spec so changes like this need to be added as "overrides" internally in our tooling first. |
|
@remi-stripe no worries at all! Definitely not urgent. Thanks for all your work 👍 |
This was referenced Jun 25, 2020
|
@driesvints We just released a fix in 7.39.0. We did our version as it needed proper prefixing for the parameter name and it's now |
|
Awesome! Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure where to send this to but thought the subscription object was probably the right place. This PR adds the different values for the
payment_behaviorfield to accommodate pending updates: https://stripe.com/docs/billing/subscriptions/pending-updates