Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call php_uname function if disabled by php.ini #829

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Don't call php_uname function if disabled by php.ini #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ApiRequestor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ private static function _defaultHeaders($apiKey, $clientInfo = null)
$uaString = 'Stripe/v1 PhpBindings/' . Stripe::VERSION;

$langVersion = phpversion();
$uname = php_uname();
$uname_disabled = in_array('php_uname', explode(',', ini_get('disable_functions')));
$uname = $uname_disabled ? '(disabled)' : php_uname();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but have we considered making that call once when the library or client is initialized and then use a cached value instead of doing that on each request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably do just that if/when I ever get to rewriting the HTTP client layer.


$appInfo = Stripe::getAppInfo();
$ua = [
Expand Down