Diffs from codegen #809
Diffs from codegen #809
Conversation
|
There still is a fix for |
|
Cool, then a patch would likely be appreciated but I can probably take! |
| $this->refreshFrom($response, $opts); | ||
| return $this; | ||
| } | ||
| use ApiOperations\NestedResource; |
There was a problem hiding this comment.
Minor but I'd recommend having this at the top. It's really easy to miss and it's an important concept core to those classes
| @@ -201,6 +256,8 @@ public static function allCapabilities($id, $params = null, $opts = null) | |||
| return self::_allNestedResources($id, static::PATH_CAPABILITIES, $params, $opts); | |||
| } | |||
|
|
|||
| const PATH_EXTERNAL_ACCOUNTS = '/external_accounts'; | |||
There was a problem hiding this comment.
This was useful when we were writing code manually. I wonder if it isn't cleaner/easier to just have the route in the function now.
There was a problem hiding this comment.
Stupid PHP question: would removing those constants be a backwards-breaking change? Not sure if they are public or not.
I think we should definitely fix this. See e.g. this issue: #793. Ideally, we would replace all instances of
We don't have to fix everything at once, but we should at least not make the current state worse. |
|
Awesome, thanks for the feedback! I think those should all be pretty feasible; hopefully we'll be able to get through them next week. |
|
Closing in favor of #837. |
r? @ob-stripe
cc @marko-stripe @remi-stripe
cc @stripe/api-libraries
The biggest difference I can find is that we no longer output
|nullfor optional fields in comments. Should we? I don't think it should be too hard.There are a few other comment regressions, like
Feels on how important those are to fix? Should be doable.