Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pending_setup_intent property in Subscription #714

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

daganM
Copy link
Contributor

@daganM daganM commented Aug 27, 2019

It just seems like this property doesn't exist in the Subscription object. I just added it.

Source : https://stripe.com/docs/api/subscriptions/object#subscription_object-pending_setup_intent

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Requested one change to ensure consistency.

lib/Subscription.php Outdated Show resolved Hide resolved
@ob-stripe ob-stripe merged commit f46bdbc into stripe:master Aug 28, 2019
@daganM daganM deleted the add-property-for-pending-setup-intent branch August 29, 2019 07:39
@ob-stripe
Copy link
Contributor

Released as 6.43.1.

@daganM
Copy link
Contributor Author

daganM commented Aug 29, 2019

Wonderful! Thank you for your quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants