Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yield for autopagination #703

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Use yield for autopagination #703

merged 1 commit into from
Aug 22, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Replace the AutoPagingIterator class with a generator function. Fixes a 3+ years old frustration of mine :)

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator-based implementation looks great! LGTM.

@ob-stripe ob-stripe merged commit 1eb95e2 into integration-v7 Aug 22, 2019
@ob-stripe ob-stripe deleted the ob-use-yield branch August 22, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants