Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the return type to static for more operations #647

Merged
merged 1 commit into from
May 7, 2019
Merged

Set the return type to static for more operations #647

merged 1 commit into from
May 7, 2019

Conversation

simon-tma
Copy link
Contributor

Helps with static analysis.

@virgofx
Copy link
Contributor

virgofx commented May 2, 2019

👍 I meant to do these in my last checkin. Thanks @simon-tma

@virgofx
Copy link
Contributor

virgofx commented May 6, 2019

@ob-stripe Can we get this merged and a new point release created? Thanks!

@ob-stripe ob-stripe merged commit ecb871d into stripe:master May 7, 2019
@ob-stripe
Copy link
Contributor

Released as 6.34.5.

@simon-tma simon-tma deleted the static-return branch May 7, 2019 00:58
@simon-tma
Copy link
Contributor Author

@ob-stripe Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simon-tma @virgofx @ob-stripe @stripe-ci