Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not bother removing friendsofphp/php-cs-fixer #1569

Merged
merged 1 commit into from
Sep 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ jobs:
# that, so we hash on "composer.json" instead.
key: ${{ runner.os }}-composer-${{ hashFiles('composer.json') }}

# We run php-cs-fixer in a separate job, but the version we use is not compatible
# with all the versions of PHP that we want to execute PHPStan upon
- name: Trim dependency
run: composer remove --dev --no-update friendsofphp/php-cs-fixer
richardm-stripe marked this conversation as resolved.
Show resolved Hide resolved

- name: Validate composer.json
run: composer validate

Expand Down